[PERF IMPROVEMENT] Add amdgpu-waves-per-eu fn_attrs to kernels.#39
Merged
yaoliu13 merged 1 commit intoamd-integrationfrom May 2, 2026
Merged
Conversation
kevinjosephamd
force-pushed
the
perf/kejoseph/configure-waves-per-eu
branch
from
4811714 to
c1643cb
Compare
kevinjosephamd
changed the title
kevinjosephamd
changed the title
Collaborator
|
/run-ci |
Collaborator
|
/run-ci |
kevinjosephamd
force-pushed
the
perf/kejoseph/configure-waves-per-eu
branch
4 times, most recently
from
d352648 to
cb415d1
Compare
kevinjosephamd
changed the title
Depends on ROCm/quadrants#11 (per-kernel fn_attrs support). Values picked from a per-kernel sweep of (min,max) occupancy hints: kernel_step_1: 3,4 kernel_step_2: 1,4 func_solve_init: 2,4
kevinjosephamd
force-pushed
the
perf/kejoseph/configure-waves-per-eu
branch
from
cb415d1 to
a89127c
Compare
Author
|
/run-ci |
jamesETsmith
approved these changes
May 1, 2026
jamesETsmith
left a comment
jamesETsmith
left a comment
There was a problem hiding this comment.
@kevinjosephamd can you create an issue to follow up on this in the future to make sure it's not hurting performance on different workloads (like you mention in the PR description)?
Collaborator
|
1355088 and 5044 |
Collaborator
|
Waiting for pre-submit of #60 and ROCm/quadrants#15 |
Collaborator
|
1355088 and 5044 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fn_attrssupport).kernel_step_1kernel_step_2func_solve_init